ramanathan1504 commented on PR #4153: URL: https://github.com/apache/logging-log4j2/pull/4153#issuecomment-5129297636
Verified locally — build green, 6/6 tests pass, spotless clean. Both my asks are done: @JWT007's commits are here with authorship intact, and all three threads from #3510 are addressed. Two things before merge. The diff drops `ATTR_MATCH` and renames `setMatchString` → `setText` with no deprecated alias — 2.x deliberately kept both (`setMatchString` is `@Deprecated since 2.25.0` alongside the new `setText`), so this diverges from the thing it ports. And the changelog entry should go: our recent ports (#4152, #4154, #4157, #4128) all added none, since the fix already has its 2.x entry and the bug never shipped in a released 3.x. Minor: the description mentions a post-`stop()` guard test that isn't there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
