vy commented on code in PR #4222:
URL: https://github.com/apache/logging-log4j2/pull/4222#discussion_r3699847454
##########
pom.xml:
##########
@@ -380,6 +380,8 @@
<log4j.docgen.pluginDescriptorsDir.phase1>${maven.multiModuleProjectDirectory}/target/plugin-descriptors/phase1</log4j.docgen.pluginDescriptorsDir.phase1>
<log4j.docgen.pluginDescriptorsDir.phase2>${maven.multiModuleProjectDirectory}/target/plugin-descriptors/phase2</log4j.docgen.pluginDescriptorsDir.phase2>
+ <!-- log4j-api-kotlin> -->
+ <log4j-api-kotlin.version>1.5.0</log4j-api-kotlin.version>
Review Comment:
This Maven property neither overrides an existing one, nor is used elsewhere
but in one place. Hence, you better inline this value, no need for a property.
##########
pom.xml:
##########
@@ -497,6 +499,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api-kotlin</artifactId>
Review Comment:
Note the comment beginning at the beginning of this `<dependencies>` block:
> List of managed dependencies (*in alphabetical order*) ...
Hence, `log4j-api-kotlin` should be placed after `log4j-api` and before
`log4j-api-test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
