vy commented on code in PR #4116: URL: https://github.com/apache/logging-log4j2/pull/4116#discussion_r3774056748
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilderTest.java: ########## Review Comment: `DefaultComponentBuilderTest` only tests the new generic API; it neither reproduces the properties failure from #2791, nor fails against the original code. Can you make sure both of these remarks are addressed, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
