vy commented on code in PR #4220: URL: https://github.com/apache/logging-log4j2/pull/4220#discussion_r3774191167
########## src/changelog/.2.x.x/3816_legacy_instant_pattern_precision.xml: ########## @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> + <description format="asciidoc">Fix precision detection in `InstantPatternLegacyFormatter` for legacy fractional-second patterns using `n`</description> Review Comment: ```suggestion <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> <description format="asciidoc">Fix precision detection in `InstantPatternLegacyFormatter` for legacy fractional-second patterns using `n`</description> ``` ########## src/changelog/.2.x.x/3816_legacy_instant_pattern_precision.xml: ########## @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> + <description format="asciidoc">Fix precision detection in `InstantPatternLegacyFormatter` for legacy fractional-second patterns using `n`</description> Review Comment: ```suggestion <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> <issue id="3816" link="https://github.com/apache/logging-log4j2/issues/3816"/> <description format="asciidoc">Fix precision detection in `InstantPatternLegacyFormatter` for legacy fractional-second patterns using `n`</description> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
