SebTardif commented on PR #4185:
URL: https://github.com/apache/logging-log4j2/pull/4185#issuecomment-5281101607
@vy Follow-ups from your review are on the tip (`b4153d59`):
1. Dropped the redundant `assertNotNull` next to `assertInstanceOf`.
2. `LoggerDynamicMBeanTest` now registers the logger MBean on an
`MBeanServer` (same `ObjectName("log4j", "logger", name)` shape as
`HierarchyDynamicMBean.addLoggerMBean`) and drives `addAppender` through
`mbeanServer.invoke`.
Could you take another look when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
