AzazelSensei opened a new pull request, #4252:
URL: https://github.com/apache/logging-log4j2/pull/4252

   `Log4j2EventListener` is also created from `spring.factories`, so 
`@ConditionalOnProperty` never applies and 
`spring.cloud.config.watch.enabled=false` does nothing.
   
   I check that property in `onApplicationEvent` (via `EnvironmentAware` or the 
event source context). Explicit `false` skips the reload. Missing or true keeps 
the old behavior.
   
   Fixes #4244
   
   ## Checklist
   
   * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` 
otherwise
   * `./mvnw verify` succeeds ([the build 
instructions](https://logging.apache.org/log4j/2.x/development.html#building))
   * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` 
directory
   * Tests are provided
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to