swebb2066 opened a new pull request, #730: URL: https://github.com/apache/logging-log4cxx/pull/730
This PR centralises decoding logic and uses the Unicode replacement character codepoint to indicate a failure. The other changes are: * UTF-8 encoding is available (using CharsetEncoder::getUTF8Encoder()) when Log4cxx is built using LOG4CXX_CHARSET=utf-8. (Prior to this PR, when Log4cxx was built using LOG4CXX_CHARSET=utf-8, the CharsetEncoder::getUTF8Encoder() function returned a TrivialCharsetEncoder.) * The Telnet appender uses the Unicode replacement character codepoint to indicate a message encoding failure. (Prior to this PR, it used a '?' character). * The ```encode3_1``` test case in ```transcodertestcase``` now works when LOG4CXX_CHAR=wchar_t (0xff is a valid UTF-16 codepoint). (Prior to this PR, the 0xff character was converted to a '?' by the ```LOGUNIT_ASSERT_EQUAL``` implementation for wchar_t). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
