ramanathan1504 commented on PR #4153: URL: https://github.com/apache/logging-log4j2/pull/4153#issuecomment-5369936842
> > @ramanathan1504, agreed — changing it to 2.25.0. setMatchString was first deprecated in Log4j 2.25.0 (where the setText replacement was introduced), so that’s when the API genuinely became deprecated. On main it arrives already deprecated rather than newly deprecated in 3.0.0, so recording the actual origin keeps the metadata consistent across 2.x and main. > > Pushed as [dd5cc8a](https://github.com/apache/logging-log4j2/pull/4153/commits/dd5cc8a5c6092a3f8b14078d3c244fd7c8075bc6). Thanks for the careful review. > > By the way, would you like me to squash or rebase the commits before merging? > > @vpelikh > > On the `@Deprecated(since)` — my question sent you the wrong way, sorry. I should have checked the branch first: `git grep -h -o 'Deprecated(since = "[^"]*"' origin/main -- '*.java'` gives 18 × `"3.0"` and 3 × `"3.0.0"`, no 2.x anywhere. And in the file itself `setText` is `@since 3.0.0`, so as it stands the alias is deprecated before its replacement exists. could you just revert [dd5cc8a](https://github.com/apache/logging-log4j2/commit/dd5cc8a5c6092a3f8b14078d3c244fd7c8075bc6)? `@since` on `getText`/`setText` is right as is. can you wait i will check and clear because its connected with couple of `pr` and `issue`,so something come from old build in my machine i think.that's why i ran the workflow. i will take care Remaining all are good Thanks LGTM! @vpelikh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
