ramanathan1504 commented on code in PR #4229: URL: https://github.com/apache/logging-log4j2/pull/4229#discussion_r3843601101
########## src/changelog/.2.x.x/fix_posix_view_attribute_symlink.xml: ########## @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4229" link="https://github.com/apache/logging-log4j2/pull/4229"/> + <description format="asciidoc">Stop `PosixViewAttribute` from applying permissions and ownership through symbolic links</description> Review Comment: Could the entry say which configuration changes? As written, a reader with links in their log directory cannot tell whether this affects them. ```suggestion <description format="asciidoc">Stop `PosixViewAttribute` from applying permissions and ownership through symbolic links found in `basePath` unless `followLinks` is set to `true`.</description> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
