ramanathan1504 commented on code in PR #4226: URL: https://github.com/apache/logging-log4j2/pull/4226#discussion_r3877937652
########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/CronTriggeringPolicyTest.java: ########## Review Comment: Remove Javadoc comments and inline comments ########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/CronExpressionTest.java: ########## Review Comment: Remove inline and Javadoc things ########## src/changelog/.2.x.x/fix_cron_triggering_policy_slow_startup.xml: ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4226" link="https://github.com/apache/logging-log4j2/pull/4226"/> + <description format="asciidoc"> + Fix a multi-second startup delay in `CronTriggeringPolicy` for appenders configured without a `fileName`. + `CronExpression.getPrevFireTime()` now bounds its backward search at 1970 instead of scanning millennia of + candidate dates before returning `null`. Review Comment: ```suggestion Changes `CronTriggeringPolicy` startup delay and name its direct write files after the rollover period. ``` ########## src/changelog/.2.x.x/fix_cron_triggering_policy_slow_startup.xml: ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> Review Comment: ```suggestion type="changed"> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
