arimu1 commented on PR #4246: URL: https://github.com/apache/logging-log4j2/pull/4246#issuecomment-5449203821
Thanks for the review, @vy — CI should be green now. `AbstractDatabaseAppenderTest.testAppend` was failing because the Mockito mock’s `isRunning()` is final and defaults to `false`, so `write()` returned early after the production guard. The test now uses a spy of a stub manager and calls `startup()` so the happy path still exercises `writeThrough()`. Failed-startup behavior remains covered by `AbstractDatabaseManagerTest` (`testFailedStartupSkipsWrite`, `testFailedStartupStillShutsDown`, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
