ppkarwasz commented on code in PR #4264: URL: https://github.com/apache/logging-log4j2/pull/4264#discussion_r3889373706
########## src/site/antora/modules/ROOT/partials/manual/configuration-xml-format.adoc: ########## @@ -18,6 +18,17 @@ [id=xml-features] = XML format +Log4j 2 parses XML configuration files with the following parser features: + +* DTD validation and the retrieval of external DTDs and external entities are **disabled**. Review Comment: I think that setting `setExpandEntityReferences(false)` is a bug we should correct and #4162 corrects it. The only effect of the setting is as you describe: the text node is wrapped in an `EntityReference` and we drop that node. It has **no** impact on fetching external references, only on the internal ones and I would leave it as implementation details **without** documenting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
