vy commented on code in PR #4256:
URL: https://github.com/apache/logging-log4j2/pull/4256#discussion_r4036407200


##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessorPublicSetterTest.java:
##########
@@ -154,17 +155,13 @@ void explicitNoteKindBehavesLikeDefault(final String 
kindValue) {
     }
 
     @Test
-    void invalidKindValueEmitsWarning() {
+    void invalidKindValueDoesNotEmitWarningByDefault() {

Review Comment:
   Anyway, changed in 418976ab09.



##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/GraalVmProcessor.java:
##########
@@ -102,7 +102,7 @@ public synchronized void init(ProcessingEnvironment 
processingEnv) {
                                 GraalVmProcessor.class.getName(),
                                 kindValue,
                                 
PluginProcessor.MIN_ALLOWED_MESSAGE_KIND_OPTION,
-                                Diagnostic.Kind.NOTE,
+                                Diagnostic.Kind.ERROR,
                                 Arrays.toString(Diagnostic.Kind.values())));

Review Comment:
   Got it. Fixed in 418976ab09.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to