ramanathan1504 commented on code in PR #4327: URL: https://github.com/apache/logging-log4j2/pull/4327#discussion_r4066281255
########## src/changelog/.3.x.x/4262_console_immediate_flush.xml: ########## @@ -0,0 +1,10 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4262" link="https://github.com/apache/logging-log4j2/issues/4262"/> Review Comment: #3161 asks the port's changelog to link the original PR. ```suggestion <issue id="4262" link="https://github.com/apache/logging-log4j2/issues/4262"/> <issue id="4325" link="https://github.com/apache/logging-log4j2/pull/4325"/> ``` ########## src/changelog/.3.x.x/4262_console_immediate_flush.xml: ########## @@ -0,0 +1,10 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4262" link="https://github.com/apache/logging-log4j2/issues/4262"/> + <description format="asciidoc"> + Fixes the `ConsoleAppender` builder to honor the configured `immediateFlush` setting instead of always flushing after each event. Review Comment: Same text as the `2.x` entry in #4325. ```suggestion Honor the `immediateFlush` setting in `ConsoleAppender`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
