efegokdemir commented on code in PR #4359: URL: https://github.com/apache/logging-log4j2/pull/4359#discussion_r4149809279
########## src/changelog/.2.x.x/4346_default_keystore_type.xml: ########## @@ -0,0 +1,10 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="4346" link="https://github.com/apache/logging-log4j2/issues/4346"/> Review Comment: Correction: current HEAD 357b697 links both issue 4346 and PR 4359 in the changelog. ########## log4j-core-test/src/test/java/org/apache/logging/log4j/core/net/ssl/SslConfigurationFactoryTest.java: ########## @@ -91,6 +92,19 @@ void testStaticConfiguration() { assertNotNull(sslConfiguration.getTrustStoreConfig()); } + @Test + void testStoreLocationWithoutTypeUsesDefaultType() { + final Properties props = new Properties(); + props.setProperty(KEYSTORE_LOCATION_PROP_NAME, SslKeyStoreConstants.KEYSTORE_LOCATION); Review Comment: Correction: current HEAD 357b697 covers both key-store and trust-store locations without an explicit type and verifies the default type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
