FreeAndNil commented on PR #334: URL: https://github.com/apache/logging-log4net/pull/334#issuecomment-5984291954
Thanks @Snotface, the backup counting bugs you found are real and your `InitializeRollBackups` tests pin them down well. The PR is more than we want in `RollingFileAppender` for a patch release though: - a new public property - size rolling switched off - a FATAL line in the user's log - false positives: `.yyyy` with `maxSizeRollBackups` 10 can never meet backup 2024 Here is a smaller fix for the same bugs on top of your branch, with your tests and a changelog entry: https://github.com/apache/logging-log4net/commit/ba511c5cf23a453751a7ba9aed16801f6fc48289 Its diff shows what changed against your version. Could you merge or cherry-pick it into your branch and push? It applies without conflicts, and we squash when merging the PR. ``` git switch feature/apache-date-aware-backup-index git pull https://github.com/apache/logging-log4net.git Feature/334-rollingfileappender-backup-index git push ``` The short date collision (`.dd`) is existing behaviour and deserves its own issue. One more request: please keep PR descriptions and changelog entries short. A few lines on what is broken and how it is fixed are much easier to review than a long write-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
