Shekharrajak commented on code in PR #4411:
URL: https://github.com/apache/logging-log4j2/pull/4411#discussion_r4390860701


##########
log4j-couchdb/src/main/java/org/apache/logging/log4j/couchdb/CouchDbConnection.java:
##########
@@ -51,8 +47,8 @@ public DefaultNoSqlObject[] createList(final int length) {
     }
 
     @Override
-    public Set<String> getReservedFieldNames() {
-        return RESERVED_FIELD_NAMES;
+    public boolean isReservedFieldName(final String fieldName) {
+        return fieldName.startsWith("_");

Review Comment:
   Thanks for checking , moving the rules into provider-specific classpath 
resources is good idea.  updated 
https://github.com/apache/logging-log4j2/pull/4411/commits/e0ec46b7a90c0d620a35deb3babb493ee4911028
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to