wylovelyi commented on PR #4394:
URL: https://github.com/apache/logging-log4j2/pull/4394#issuecomment-6462112106
Thanks @ramanathan1504 — you're right, and I've gone with your suggestion.
I pushed a new head that reverts my prose rewrite entirely and only changes
the three patterns to `%c{1.2*}`, `%c{1.3*}` and `%c{1.8*}`. The diff is now
+3/-3 in one file, and the prose and all documented outputs are exactly as they
were.
Your point about the two abbreviators was the piece I had wrong: the period
routes to `PatternAbbreviator`, which is why `%c{1.2.*}` prints
`o.ap.commons.test.Foo`, while `DynamicWordAbbreviator` (no period) is what the
prose actually describes. I re-verified directly against `log4j-core` 2.26.1:
```text
1.2* -> o.a.c.test.Foo (table: o.a.c.test.Foo)
match
1.3* -> o.a.commons.test.Foo (table: o.a.commons.test.Foo)
match
1.8* -> org.apache.commons.test.Foo (table: org.apache.commons.test.Foo)
match
1.2.* -> o.ap.commons.test.Foo (table: o.a.c.test.Foo)
no match
```
I left `%c{1.1.1.*}` alone since all three counts are `1` and both paths
produce the same `o.a.c.test.Foo` there.
PR description updated to match. Thanks for the careful read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
