[
https://issues.apache.org/jira/browse/MYNEWT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349645#comment-16349645
]
ASF GitHub Bot commented on MYNEWT-882:
---------------------------------------
ccollins476ad closed pull request #131: MYNEWT-882 Newt - Allow spaces in paths
URL: https://github.com/apache/mynewt-newt/pull/131
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/newt/toolchain/compiler.go b/newt/toolchain/compiler.go
index cc19968b..c2e1daab 100644
--- a/newt/toolchain/compiler.go
+++ b/newt/toolchain/compiler.go
@@ -347,7 +347,8 @@ func (c *Compiler) includesStrings() []string {
return nil
}
- includes := util.SortFields(c.info.Includes...)
+ includes := util.UniqueStrings(c.info.Includes)
+ sort.Strings(includes)
tokens := make([]string, len(includes))
for i, s := range includes {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Newt - Problems with spaces in paths
> ------------------------------------
>
> Key: MYNEWT-882
> URL: https://issues.apache.org/jira/browse/MYNEWT-882
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
> Reporter: Christopher Collins
> Assignee: Christopher Collins
> Priority: Major
>
> A user from the #general slack channel (Anup) reported an issue involving
> spaces in path names.
> The summary is:
> {noformat}
> 2018/01/07 18:57:21.699 [DEBUG]
> o=repos/apache-mynewt-core/boot/bootutil/src/bootutil_misc.c:24:10: fatal
> error: syscfg/syscfg.h: No such file or directory
> {noformat}
> {noformat}
> -IBhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include
> {noformat}
> The full include path should be: {{C:/msys64/home/Anup
> Bhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include}}
> The full build log is here:
> https://mynewt.slack.com/files/U8P49MQ83/F8P7W856W/-.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
