vandy opened a new pull request, #1849: URL: https://github.com/apache/mynewt-nimble/pull/1849
This PR is related to #1846. These were the thoughts during gatt offset research. One of the concerns is unnecessary (as it seems to me) arguments passed down the line to functions. It confuses a little about real dependencies. The idea behind joining `ble_l2cap_parse_hdr` and `os_mbuf_adj` is to make it similar to `ble_hs_hci_util_data_hdr_strip`, as `ble_l2cap_parse_hdr` is not used anywhere outside the function. The main concern is that `ble_l2cap_rx` and `ble_l2cap_rx_payload` besides business logic are messing with mbuf processing and other "infrastructure" stuff. Mixing logic from different layers of abstraction. This functions would be simpler if they just did l2cap processing and returning error codes immediately and the caller made cleaning and processing. So `ble_hs_hci_evt_acl_process` could clean the buffer as it already does, also schedule a timer on l2cap fragments as it already knows about fragments in the switch block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
