andrzej-kaczmarek commented on code in PR #1857:
URL: https://github.com/apache/mynewt-nimble/pull/1857#discussion_r1756713589
##########
nimble/controller/src/ble_ll_adv.c:
##########
@@ -1959,7 +1964,7 @@ ble_ll_adv_update_adv_scan_rsp_data(struct ble_ll_adv_sm
*advsm)
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
/* DID shall be updated when host provides new advertising data */
- ble_ll_adv_update_did(advsm);
+ advsm->adi = ble_ll_adv_update_did(advsm->adi);
Review Comment:
put changes related to ble_ll_adv_update_did in separate commit
##########
nimble/controller/src/ble_ll_sync.c:
##########
@@ -2133,8 +2168,15 @@ ble_ll_sync_periodic_ind(struct ble_ll_conn_sm *connsm,
sm->anchor_point = sm->sch.start_time + g_ble_ll_sched_offset_ticks;
sm->anchor_point_usecs = sm->sch.remainder;
- if (reports_disabled) {
+ switch (mode) {
+ case 0x1:
sm->flags |= BLE_LL_SYNC_SM_FLAG_DISABLED;
+ break;
+ case 0x3:
Review Comment:
case 0x2 missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
