kasjer commented on code in PR #3321: URL: https://github.com/apache/mynewt-core/pull/3321#discussion_r1810001157
########## hw/hal/include/hal/hal_os_tick.h: ########## @@ -49,6 +49,12 @@ void os_tick_init(uint32_t os_ticks_per_sec, int prio); */ void os_tick_idle(os_time_t n); +/** + * Calculate the OS tick parameters. + * + * @param os_ticks_per_sec The number of OS ticks per second + */ +void hal_os_tick_calc_params(uint32_t os_ticks_per_sec); Review Comment: I'm not convinced. There is no code (in public repository) that requires this prototype. Even file in this commit does not need this. If I was to implement this function for other MCU I would not know what is the purpose, why OS needs it and when it should be called. To make your case it would be nice to have other code that utilizes this functionality. For now this function could be static in your hal_os_tick.c without any prototype. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
