andrzej-kaczmarek commented on PR #3321: URL: https://github.com/apache/mynewt-core/pull/3321#issuecomment-2430489862
> > Please don't move code around in `.c` files - this breaks git annotate > > Yeah, keeping the git annotate may indeed outweigh the benefits of having the functions in a neat order. To that extent, should I keep the "da1469x/clock: Eliminate magic numbers" commit, or should I leave those lines unchanged as well? Keep it, removing magic numbers is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
