sjanc commented on code in PR #1813:
URL: https://github.com/apache/mynewt-nimble/pull/1813#discussion_r1818826573
##########
apps/bttester/src/btp_gap.c:
##########
@@ -2000,6 +2001,47 @@ set_filter_accept_list(const void *cmd, uint16_t cmd_len,
return BTP_STATUS_SUCCESS;
}
+#if MYNEWT_VAL(BLE_EXT_ADV)
+static uint8_t
+set_ext_advertising(const void *cmd, uint16_t cmd_len,
+ void *rsp, uint16_t *rsp_len)
+{
Review Comment:
This should only set this in current settings and set adv_param->legacy_pdu
accordingly
Also, if advertising is already enabled this may simply fail, if ext_adv is
not enabled in syscfg it should also fail.
so in short:
```
if (cp->setting) {
current_settings |= BIT(BTP_GAP_SETTINGS_EXTENDED_ADVERTISING);
adv_param->legacy_pdu = 0;
} else {
current_settings &= ~BIT(BTP_GAP_SETTINGS_EXTENDED_ADVERTISING);
adv_param->legacy_pdu = 1;
}
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
