sjanc commented on code in PR #1906:
URL: https://github.com/apache/mynewt-nimble/pull/1906#discussion_r1824722084
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -307,8 +307,9 @@ ble_svc_audio_bass_add_source(uint8_t *data, uint16_t
data_len, uint16_t conn_ha
operation.conn_handle = conn_handle;
operation.add_source.adv_addr.type = data[offset++];
- if (operation.add_source.adv_addr.type != BLE_ADDR_PUBLIC ||
- operation.add_source.adv_addr.type != BLE_ADDR_RANDOM) {
+
+ if (!(operation.add_source.adv_addr.type != BLE_ADDR_PUBLIC ||
Review Comment:
so what is the intention here? which address types are allowed? 0x00 and
0x01?
Asking cause this check looks rather unorthodox...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
