kasjer commented on code in PR #3339:
URL: https://github.com/apache/mynewt-core/pull/3339#discussion_r1834387502
##########
hw/mcu/dialog/da1469x/include/mcu/da1469x_hal.h:
##########
@@ -94,6 +94,23 @@ const struct qspi_flash_config
*da1469x_qspi_get_config(void);
*/
void hal_os_tick_calc_params(uint32_t cycles_per_sec);
+/**
+ * Configure GPIO using a single value.
+ *
+ * @param pin GPIO ID
+ * @param raw_mode Combined mode / I/O properties value
Review Comment:
You could add description of what ***mode*** and ***I/O properties*** mean.
Maybe mention MCU_GPIO_MODE_xxxx and MCU_GPIO_FUNC_xxxx constants.
##########
hw/mcu/dialog/da1469x/src/hal_gpio.c:
##########
@@ -491,6 +491,24 @@ mcu_gpio_set_pin_function(int pin, int mode, mcu_gpio_func
func)
__HAL_ENABLE_INTERRUPTS(primask);
}
+void
+mcu_gpio_set_pin_function_raw(int pin, uint32_t raw_mode)
Review Comment:
Once this function is present maybe `mcu_gpio_set_pin_function()` (previous
one) could just call this one to have just one way of dealing with interrupts
and latching in case some modification is needed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
