vrahane commented on code in PR #3365:
URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1956643783
##########
sys/log/full/src/log_fcb2.c:
##########
@@ -476,12 +485,13 @@ log_fcb2_walk(struct log *log, log_walk_func_t walk_func,
struct fcb_log *fcb_log;
struct fcb2_entry loc;
int rc;
+ int min_diff = -1;
Review Comment:
`min_diff` seemed fine because it is the minimum difference in distance
between the entry and the bookmark when a match is found, otherwise it stays
-1. If an exact match is found it's 0 which also fits its purpose and name. Do
you have any other name in mind ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
