vrahane commented on code in PR #3365: URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1956647462
########## sys/log/full/src/log_fcb.c: ########## @@ -108,6 +110,7 @@ fcb_walk_back_find_start(struct fcb *fcb, struct log *log, struct log_offset *lo * ignored; the "index" field is used instead. * * XXX: We should rename "timestamp" or make it an actual timestamp. + * If bmark is found, fill up min_diff. Review Comment: Since it was a static function, I didn't explain it much but I explained it for a public api here: https://github.com/apache/mynewt-core/pull/3365/files#diff-a8268376783e79148c79b3f1117fc7f0bd35d55ff075dfc20779e8063496e561R165. Added a comment explaining it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
