vrahane commented on code in PR #3365: URL: https://github.com/apache/mynewt-core/pull/3365#discussion_r1958762174
########## sys/log/full/src/log_fcb2.c: ########## @@ -47,14 +47,16 @@ static int log_fcb2_rtr_erase(struct log *log); * The "index" field corresponds to a log entry index. * * If bookmarks are enabled, this function uses them in the search. + * For min_diff, if bookmark was found, fill it up with the difference + * else it will return -1. Review Comment: I will give it another shot, if you don't like that one, you can change it yourself or you can suggest something specific. It is a static function, so, no external users will use it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
