vrahane commented on code in PR #3382:
URL: https://github.com/apache/mynewt-core/pull/3382#discussion_r1992140419
##########
fs/fcb/src/fcb.c:
##########
@@ -118,14 +124,29 @@ fcb_free_sector_cnt(struct fcb *fcb)
break;
}
}
+
+ os_mutex_release(&fcb->f_mtx);
+
return i;
}
int
fcb_is_empty(struct fcb *fcb)
{
- return (fcb->f_active.fe_area == fcb->f_oldest &&
+ int rc = 0;
+ bool ret = false;
+
+ rc = os_mutex_pend(&fcb->f_mtx, OS_WAIT_FOREVER);
+ if (rc && rc != OS_NOT_STARTED) {
+ return FCB_ERR_ARGS;
Review Comment:
I think using the return code is good enough, will just update the header to
include the updated return code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
