vrahane commented on code in PR #3400:
URL: https://github.com/apache/mynewt-core/pull/3400#discussion_r2076108267
##########
sys/log/full/src/log.c:
##########
@@ -320,21 +324,41 @@ log_read_hdr_walk(struct log *log, struct log_offset
*log_offset, const void *dp
}
}
+ if (arg->hdr->ue_flags & LOG_FLAGS_TRAILER_SUPPORT && log->l_th) {
+#if MYNEWT_VAL(LOG_FLAGS_TRAILER_SUPPORT)
+ if (log->l_th->log_process_trailer) {
Review Comment:
That is exactly why `l_trailer_arg` was there. If an application needs to
process the data, they will have to implement the process callback in which the
data will get read during the correct function calls in the logging code. If
you want to read data, a separate callback will have to be implemented which is
not really necessary for the implementation right now as the data is handled by
the implemented callbacks, so, an application registering those callbacks
already has access to the data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
