sjanc commented on code in PR #3431:
URL: https://github.com/apache/mynewt-core/pull/3431#discussion_r2143512463
##########
.github/workflows/check_compliance.yml:
##########
@@ -42,13 +42,18 @@ jobs:
sudo apt-get install -y clang-format
- name: Check formatting (diff only)
+ shell: bash
run: |
+ set +e
+
INFO_URL="https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md";
git diff -U0 origin/master...HEAD > diff.patch
clang-format-diff -p1 -style=file < diff.patch > clang-fmt.patch
if [ -s clang-fmt.patch ]; then
echo "Code formatting issues found:"
cat clang-fmt.patch
- exit 1
+ echo ""
+ echo "For formatting guidelines, see:"
+ echo " $INFO_URL"
Review Comment:
why 'exit 1' is removed? job should fail on style issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
