andrzej-kaczmarek commented on code in PR #1882:
URL: https://github.com/apache/mynewt-nimble/pull/1882#discussion_r2276638657
##########
nimble/transport/syscfg.yml:
##########
@@ -29,6 +29,7 @@ syscfg.defs:
- native
- dialog_cmac
- nrf5340
+ - ipc
Review Comment:
`icbmsg` or `ipc_icbmsg` - I think the latter is more preferable as we may
later opt rename nrf5340 and cmac to include `ipc_` prefix as well -> @sjanc ?
##########
nimble/controller/syscfg.yml:
##########
@@ -226,6 +226,11 @@ syscfg.defs:
Enables LLCP tracing using HCI vendor-specific events.
value: '0'
+ BLE_LL_HCI_NOOP_AFTER_INIT:
Review Comment:
this should be a separate commit
##########
nimble/transport/ipc/syscfg.yml:
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+syscfg.defs:
+ BLE_TRANSPORT_IPC_BACKEND:
+ description: >
+ Select IPC backend.
Review Comment:
skip the intermediate `ipc` transport package, `icbmsg` should be directly
included from `nimble/transport`
##########
nimble/transport/common/hci_ipc/include/nimble/transport/hci_ipc.h:
##########
@@ -21,13 +21,26 @@
#define _HCI_IPC_H_
#include <stdint.h>
+#include <syscfg/syscfg.h>
+#if MYNEWT_VAL(IPC_ICBMSG)
+#include "nimble/hci_common.h"
+#define HCI_IPC_TYPE_CMD 0x01
+#define HCI_IPC_TYPE_ACL 0x02
+/* #define HCI_IPC_TYPE_SCO 0x03 */
+#define HCI_IPC_TYPE_EVT 0x04
+#define HCI_IPC_TYPE_ISO 0x05
+/* These two are not used actually */
+#define HCI_IPC_TYPE_EVT_DISCARDABLE 0x06
Review Comment:
so looks like icbmsg uses simple H4, in such case it should simply use hci_h4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
