[ 
https://issues.apache.org/jira/browse/MYNEWT-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037572#comment-16037572
 ] 

Marko Kiiskila commented on MYNEWT-771:
---------------------------------------

The version of Nordic SDK we're using does not have references to 
NRF_LOG_INFO(); are you using some other version? See 
https://github.com/runtimeco/mynewt_nordic what we're currently using.

You could consider driver API, instead of HAL API. An example of this is ADC; 
ADC drivers for nrf51/nrf52 are present in the nordic repo. We have not (or at 
least I have not) discussed about how to interface with NFC. If you have ideas 
in mind, you could propose those in the dev mailing list.

Coming up with a meaningful/useful API boundary can be difficult. I admit I 
don't have experience with NFC, so I'm of limited use in terms of advice about 
what makes sense here. I can just offer platitude here; having a driver API 
would allow users to write libraries/applications which can use the same API 
regardless of what hardware it uses for NFC.

Limitation we have is that nothing in MyNewt can depend on header files/sources 
which have incompatible licenses from Apache. That is why we can keep the HAL 
drivers we have for Nordic in apache-incubator-core (only #include files which 
have compatible license), but have to have the ADC drivers outside (they were 
moved to mynewt_nordic repo I mentioned).

> HAL for NRF52 NFCT
> ------------------
>
>                 Key: MYNEWT-771
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-771
>             Project: Mynewt
>          Issue Type: Wish
>      Security Level: Public(Viewable by anyone) 
>          Components: HAL
>    Affects Versions: WISHLIST
>         Environment: NRF52
>            Reporter: Jeff Chan
>            Assignee: Marko Kiiskila
>            Priority: Minor
>              Labels: NFC, nrf52832
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I would like to use the NFC Tag feature of the NRF52 Chip.
> The Nordic SDK supplies a number of .h/.c files to wrap the hardware 
> registers and provide Type 2/Type 4 and NDEF features; Related peripherals 
> such as clock/power control as well as a number of hardware bug fixes.
> There's a certain degree of difficulty in just copying in/linking in files 
> because of NRF SDK specific logging commands such as NRF_LOG_INFO.
> I suspect that NFC will become a larger part of our lives at some point, so 
> is it something that can be integrated into mynewt? Or should NFC be in a 
> sideline repo?
> To what point must we abstract each layer?  For example, should we create a 
> new agnostic NFC Tag layer HAL?  What about read/writes, NDEF or type 2/4 tag 
> layers?  
> What I'm aiming at is that there are several layers that all could get their 
> own "mynewt-ified" data structures.  Is it worth the effort?  Can such an 
> effort be effective since the only chips I know of that really integrates 
> NFCT is so far the NRF5 series.  Not as clear as a HAL for i2c for example.
> If we decide to pull in such logic "on the side", what's the 'right way' to 
> reuse as much of the Nordic supplied .c/.h files?  Is there a standard way of 
> stripping out proprietary logging while preserving as much of the Hardware 
> Eratta fixes?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to