jlahoda commented on a change in pull request #443: [NETBEANS-451] search for
git revision instead of mercurial one.
URL: https://github.com/apache/incubator-netbeans/pull/443#discussion_r173071617
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/HgId.java
##########
@@ -20,19 +20,22 @@
package org.netbeans.nbbuild;
import java.io.File;
-import java.io.FileInputStream;
import java.io.IOException;
-import java.io.InputStream;
-import java.math.BigInteger;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.List;
+
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.Task;
/**
- * Computes Mercurial changeset ID (in short format, i.e. 12 hex digits) of
current working copy.
- * Compared to {@code hg id -i} or even {@code hg log -r . --template
'{node|short}\n'}
+ * Computes Git changeset ID (in short format, i.e. 12 hex digits) of current
working copy.
+ * Compared to {@code git log --abbrev-commit --abbrev=12}
* it is very quick. Does not check for second merge parent or modification
status
* or tags. Sets property to {@code unknown-revn} if there is any problem.
+ *
+ * (This task formaly computed a Mercurial changeset ID hence the name)
Review comment:
Typo: this should be "formerly", not "formaly", right? Otherwise looks good
to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
