junichi11 commented on a change in pull request #2160:
URL: https://github.com/apache/netbeans/pull/2160#discussion_r432996342
##########
File path:
php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorAnalyzerImpl.java
##########
@@ -177,22 +181,49 @@ private MessDetector getValidMessDetector() {
return null;
}
+ @CheckForNull
+ private MessDetectorParams getValidMessDetectorParams() {
+ MessDetectorParams messDetectorParams = new MessDetectorParams()
+ .setRuleSets(getValidMessDetectorRuleSets())
+ .setRuleSetFile(getValidRuleSetFile());
+ ValidationResult result = new AnalysisOptionsValidator()
+ .validateMessDetector(messDetectorParams)
+ .getResult();
+ if (result.hasErrors()
+ || result.hasWarnings()) {
+ return null;
+ }
+ return messDetectorParams;
+ }
Review comment:
Please format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
