junichi11 commented on a change in pull request #2160: URL: https://github.com/apache/netbeans/pull/2160#discussion_r438517779
########## File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorParams.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.php.analysis; + +import java.util.List; +import org.openide.filesystems.FileObject; + +public final class MessDetectorParams { + + private List<String> ruleSets; + private FileObject ruleSetFile; + + public List<String> getRuleSets() { + return ruleSets; + } + + public MessDetectorParams setRuleSets(List<String> ruleSets) { + this.ruleSets = ruleSets; + return this; + } Review comment: Should use package private instead of `public`. Should add the list as a new list. i.e. ```java this.ruleSets = new ArrayList<>(ruleSets); ``` ########## File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorParams.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.php.analysis; + +import java.util.List; +import org.openide.filesystems.FileObject; + +public final class MessDetectorParams { + + private List<String> ruleSets; + private FileObject ruleSetFile; + + public List<String> getRuleSets() { + return ruleSets; Review comment: Should use `Collections.unmodifiableList()`. ########## File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/commands/MessDetector.java ########## @@ -59,10 +60,12 @@ private static final String REPORT_FORMAT_PARAM = "xml"; // NOI18N private static final String EXCLUDE_PARAM = "--exclude"; // NOI18N private static final String SUFFIXES_PARAM = "--suffixes"; // NOI18N + public static final String EMPTY_RULE_SET = "<none>"; // NOI18N Review comment: I would consider `i18N` because it is not a command or parameter. ########## File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorParams.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.php.analysis; + +import java.util.List; +import org.openide.filesystems.FileObject; + +public final class MessDetectorParams { + + private List<String> ruleSets; + private FileObject ruleSetFile; + + public List<String> getRuleSets() { + return ruleSets; + } + + public MessDetectorParams setRuleSets(List<String> ruleSets) { + this.ruleSets = ruleSets; + return this; + } + + public FileObject getRuleSetFile() { + return ruleSetFile; + } + + public MessDetectorParams setRuleSetFile(FileObject ruleSetFile) { Review comment: Should use package private instead of `public`. ########## File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/ValidatorMessDetectorParameter.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.php.analysis.options; + +import java.util.List; +import org.netbeans.modules.php.analysis.ui.analyzer.MessDetectorCustomizerPanel; +import org.netbeans.modules.php.analysis.ui.options.MessDetectorOptionsPanel; + +public final class ValidatorMessDetectorParameter { + + private final String messDetectorPath; + private final List<String> ruleSets; + private final String ruleSetFilePath; + + public static ValidatorMessDetectorParameter create(MessDetectorOptionsPanel panel) { + return new ValidatorMessDetectorParameter(panel); + } + + public static ValidatorMessDetectorParameter create(MessDetectorCustomizerPanel panel) { + return new ValidatorMessDetectorParameter(panel); + } + + private ValidatorMessDetectorParameter() { + messDetectorPath = null; + ruleSets = null; + ruleSetFilePath = null; + } + + private ValidatorMessDetectorParameter(MessDetectorOptionsPanel panel) { + messDetectorPath = panel.getMessDetectorPath(); + ruleSets = panel.getMessDetectorRuleSets(); + ruleSetFilePath = panel.getMessDetectorRuleSetFilePath(); + } + + private ValidatorMessDetectorParameter(MessDetectorCustomizerPanel panel) { + messDetectorPath = null; + ruleSets = panel.getSelectedRuleSets(); + ruleSetFilePath = panel.getRuleSetFile(); + } + + public String getMessDetectorPath() { + return messDetectorPath; + } + + public List<String> getRuleSets() { + return ruleSets; Review comment: Should use `Collections.unmodifiableList()`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
