JaroslavTulach commented on a change in pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#discussion_r448187555
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ConfigureProxy.java
##########
@@ -84,51 +84,21 @@ public void execute() throws BuildException {
static URLConnection openConnection(Task task, final URL url, URI[]
connectedVia) throws IOException {
final URLConnection[] conn = { null };
final List<Exception> errs = new CopyOnWriteArrayList<>();
+ final StringBuilder msgs = new StringBuilder();
Review comment:
Done in 40584ecfeb52cfd7f8f5bc619ad97ad968303819 - if approved, I also
merge it to `master`.
Btw. the code was ready for being used from multiple threads - see all the
`msgs.append("x' + a + " y " + b + " z" + c)` concatentations that are done in
single thread and only then placed into the `msgs` object. Why did I not used
`StringBuffer` then? I know I wanted...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
