hectorespert commented on a change in pull request #2221:
URL: https://github.com/apache/netbeans/pull/2221#discussion_r449576550
##########
File path: .github/workflows/main.yml
##########
@@ -46,35 +46,37 @@ jobs:
run: ant -f platform/core.network test
- name: Test PHP modules
+ env:
+ OPTS: -quiet -Dcluster.config=php -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true
Review comment:
@KacerCZ Please. Remove `-quiet -Dcluster.config=php
-Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false` params, it
isn't required.
##########
File path: .github/workflows/main.yml
##########
@@ -98,6 +100,164 @@ jobs:
- name: Test Netbeans Build System
run: ant -Dcluster.config=basic localtest
+
+ linux-php:
+ name: Linux build of PHP modules
+ runs-on: ubuntu-18.04
+ env:
+ OPTS: -quiet -Dcluster.config=php -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('**/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Setup PHP
+ uses: shivammathur/[email protected]
+ with:
+ php-version: '7.4'
+ tools: pecl
+ extensions: xdebug
+ ini-values: xdebug.remote_enable=on
+
+ - name: Clean
+ run: ant $OPTS clean
+
+ - name: Build
+ run: ant $OPTS build
+
+ - name: Test Hudson
+ uses: GabrielBB/xvfb-action@v1
+ with:
+ run: ant ${{ env.OPTS }} -f php/hudson.php test
+
+ - name: Test Neon
+ uses: GabrielBB/xvfb-action@v1
+ with:
+ run: ant ${{ env.OPTS }} -f php/languages.neon test
Review comment:
@KacerCZ Could you try to run Xvfb in the first steps inteads use the
`GabrielBB/xvfb-action@v1` action?
For example: https://github.com/apache/netbeans/pull/2186/files
```yaml
linux:
name: Linux build
runs-on: ubuntu-18.04
env:
DISPLAY: ":99.0"
steps:
- name: Setup JDK 8
uses: actions/setup-java@v1
with:
java-version: '8'
java-package: jdk+fx
- name: Launch Xvfb
run: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
```
##########
File path: .github/workflows/main.yml
##########
@@ -98,6 +100,164 @@ jobs:
- name: Test Netbeans Build System
run: ant -Dcluster.config=basic localtest
+
+ linux-php:
+ name: Linux build of PHP modules
+ runs-on: ubuntu-18.04
+ env:
+ OPTS: -quiet -Dcluster.config=php -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true
Review comment:
@KacerCZ Remove the `-quiet` and `-Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false` params
##########
File path: .github/workflows/main.yml
##########
@@ -98,6 +100,164 @@ jobs:
- name: Test Netbeans Build System
run: ant -Dcluster.config=basic localtest
+
+ linux-php:
+ name: Linux build of PHP modules
+ runs-on: ubuntu-18.04
+ env:
+ OPTS: -quiet -Dcluster.config=php -Djavac.compilerargs=-nowarn
-Dbuild.compiler.deprecation=false
-Dtest-unit-sys-prop.ignore.random.failures=true
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('**/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Setup PHP
+ uses: shivammathur/[email protected]
+ with:
+ php-version: '7.4'
+ tools: pecl
+ extensions: xdebug
+ ini-values: xdebug.remote_enable=on
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
