junichi11 commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r450610078
##########
File path:
php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorAnalyzerImpl.java
##########
@@ -223,6 +224,20 @@ private FileObject getValidRuleSetFile() {
return FileUtil.toFileObject(new File(ruleSetFile));
}
+ @CheckForNull
+ private String getValidOptions() {
+ String options = null;
+ Preferences settings = context.getSettings();
+ if (settings != null) {
+ options = settings.get(MessDetectorCustomizerPanel.OPTIONS, null);
+ }
+ if (options == null) {
+ options = AnalysisOptions.getInstance().getMessDetectorOptions();
+ }
+ assert options != null;
Review comment:
Remove?
##########
File path:
php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptions.java
##########
@@ -142,6 +143,15 @@ public void setMessDetectorRuleSetFilePath(String
ruleSetFilePath) {
getPreferences().put(MESS_DETECTOR_RULE_SET_FILE, ruleSetFilePath);
}
+ @CheckForNull
+ public String getMessDetectorOptions() {
+ return getPreferences().get(MESS_DETECTOR_OPTIONS, "");
Review comment:
`null` or add `NOI18N`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
