timboudreau commented on pull request #2232: URL: https://github.com/apache/netbeans/pull/2232#issuecomment-656783238
I'm not sure I'm in love with that solution for the following reason: ProxyLookup.Controller ctrl = new ProxyLookup.Controller(); ProxyLookup lookup1 = new Proxylookup(ctrl); ProxyLookup lookup2 = new ProxyLookup(ctrl); and what happens? Not to mention that ProxyLookup.Controller will need internal fields to hold any lookups set before it has been attached to a ProxyLookup, adding to the footprint unnecessarily. Seems clunkier while adding little value. -Tim On Thu, Jul 9, 2020 at 1:53 AM Jaroslav Tulach <[email protected]> wrote: > It should work the same way AbstractLookup.Content > <https://bits.netbeans.org/12.0/javadoc/org-openide-util-lookup/org/openide/util/lookup/AbstractLookup.Content.html> > does - e.g. give the creator of the ProxyLookup additional privileges by > keeping a an internal reference to Content and giving out ProxyLookup to > everyone. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/netbeans/pull/2232#issuecomment-655916926>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAOQE5ZHORJJGMRFZT5YW3LR2VLL3ANCNFSM4OQXM5SQ> > . > -- http://timboudreau.com ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
