junichi11 commented on a change in pull request #2269:
URL: https://github.com/apache/netbeans/pull/2269#discussion_r459800063
##########
File path:
php/php.editor/src/org/netbeans/modules/php/editor/indent/FormatVisitor.java
##########
@@ -1172,41 +1166,62 @@ public void visit(FunctionDeclaration node) {
@Override
public void visit(LambdaFunctionDeclaration node) {
Review comment:
I've rewritten almost of all this implementation because we should
consider [psr-12](https://www.php-fig.org/psr/psr-12/). (parameters and lexical
variables were not wrapped.)
Formatting problems related to closures are likely to occur in an
array/parameters. So especially, I've added unit tests for in arrays.
All existing unit tests also have passed. I just hope that there is no big
problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
