matthiasblaesing commented on a change in pull request #2317:
URL: https://github.com/apache/netbeans/pull/2317#discussion_r481982587
##########
File path:
platform/autoupdate.services/src/org/netbeans/api/autoupdate/OperationContainer.java
##########
@@ -352,6 +353,17 @@ public void removeAll() {
impl.removeAll ();
}
+ /** Specifies location of unpack200 executable. {@code unpack200} has been
+ * removed from JDK 14. As such it is not possible to unpack older NBM
+ * files without providing alternative JDK implementation of this file.
+ *
+ * @param executable path to the executable
+ * @since 1.65
+ */
+ public final void setUnpack200(File executable) {
+ this.impl.setUnpack200(executable);
+ }
Review comment:
Whether it it is java or not - we can call it via CLI, and most probably
that is the best idea, but it looks as if there is a java implementation:
https://github.com/pack200/pack200/blob/master/src/main/java/io/pack200/UnpackerImpl.java#L114-L117
https://github.com/pack200/pack200/blob/master/src/main/java/io/pack200/UnpackerImpl.java#L200
It was just a thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
