eirikbakke commented on pull request #2376: URL: https://github.com/apache/netbeans/pull/2376#issuecomment-694353762
I don't think we should be doing these one-by-one. It will not end up looking good, and reviewing will take much longer than if we do 50-60 of these in batch at a time. For these particularly simple icons (a single square and a single circle), making the style consistent with other icons, and ensuring alignment to the pixel grid etc., is 90% of the work. We need to do a full batch of icons from https://people.csail.mit.edu/ebakke/misc/netbeans-icons/prioritized.html , and ensure they are following some agreed-upon style guide (e.g. as proposed in https://issues.apache.org/jira/browse/NETBEANS-2617 ). Then we need to go in and make sure the vertices in the icons are aligned to pixel boundaries and so on. (As an example: In these particular two SVG icons, the style is inconsistent with existing icons because the borders are too hard. The proposed style guide in NETBEANS-2617 prescribes 33% transparency for the border, on top of the fill color. The fill color of the "Stop Macro Recording" is also too dark--the shade of the old bitmap icon was better.) So let's hold off integrating individual icons until we have a large batch done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
