matthiasblaesing commented on pull request #2382:
URL: https://github.com/apache/netbeans/pull/2382#issuecomment-696886444


   This fails the license check - the license files need to be renamed too. To 
verify yourself, you can run:
   
   ```shell
   ant verify-libs-and-licenses
   ```
   
   This yields:
   
   ```
   verify-libs-and-licenses:
   [verifylibsandlicenses] 
/home/matthias/src/netbeans/nbbuild/build/verifylibsandlicenses.xml: 1 failures 
out of 5 tests
   ```
   
   ```xml
   <?xml version="1.0" encoding="UTF-8"?><testsuite errors="0" failures="1" 
name="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" tests="5" time="0.0">
       <testcase classname="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" 
name="testNoStrayThirdPartyBinaries" time="0.0"/>
       <testcase classname="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" 
name="testLicenseFilesAreProperlyFormattedPhysically" time="0.0"/>
       <testcase classname="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" 
name="testLicenses" time="0.0">
           <failure message="Some license files have incorrect headers" 
type="junit.framework.AssertionFailedError">Some license files have incorrect 
headers
   
java/libs.springframework/external/spring-framework-3.2.18.RELEASE-license.txt 
refers to nonexistent nbbuild/licenses/Apache-2.0-spring3
   
java/libs.springframework/external/spring-framework-4.3.29.RELEASE-license.txt 
refers to nonexistent nbbuild/licenses/Apache-2.0-spring4
   
java/libs.springframework/external/spring-framework-5.2.9.RELEASE-license.txt 
refers to nonexistent nbbuild/licenses/Apache-2.0-spring5</failure>
       </testcase>
       <testcase classname="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" 
name="testBinaryUniqueness" time="0.0"/>
       <testcase classname="org.netbeans.nbbuild.extlibs.VerifyLibsAndLicenses" 
name="testLicenseinfo" time="0.0"/>
   </testsuite>
   ```
   
   As this has to updated, please rebase onto master and squash changes into 
one commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to