ebarboni edited a comment on pull request #2417:
URL: https://github.com/apache/netbeans/pull/2417#issuecomment-703571876
Hi @matthiasblaesing
maybe we could add a step to download-all-extbins to download the json file
in correct place to avoid the wget phase.
AFAIK download-all-extbins is not used in "standard build".
It make me think that step 3 -D parameters is a hack as json file should be
detected and used.
Maybe the following code on build.xml in nbbuild line 112 can avoid all the
json mess.
```
<!-- get all json info we have on apache gitbox -->
<property name="metabuild.releasejson"
value="${nb_all}/nbbuild/build/netbeansrelease.json"/>
<condition property="metabuild.jsonurl"
value="https://gitbox.apache.org/repos/asf?p=netbeans-jenkins-lib.git;a=blob_plain;f=meta/netbeansrelease.json";>
<not>
<isset property="metabuild.jsonurl"/>
</not>
</condition>
<condition property="needjson">
<not>
<available file="${metabuild.releasejson}" />
</not>
</condition>
<sequential if:set="needjson" >
<configureproxy connectTo="${metabuild.jsonurl}"
hostProperty="proxyHost" portProperty="proxyPort"/>
<setproxy proxyhost="${proxyHost}" proxyPort="${proxyPort}"/>
<get dest="${metabuild.releasejson}" skipexisting="false"
src="${metabuild.jsonurl}" />
</sequential>
<!-- read info from gitinfo.properties , if present in source bundle
copy gitinfo-->
```
EDIT to add the xml code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
