errael commented on pull request #2482: URL: https://github.com/apache/netbeans/pull/2482#issuecomment-716198323
> the underlying issue > impl should remember real bounds computed by paintCustomCaret() Who's to say this doesn't fix the underlying issue? In fact, rather than some hacky code to remember what paint did in the past, this solution allow the paint code to specify what it wants for the current character over which the caret is being painted. At least in my case the value is being provided by an ancient class I've got named "SwingPaintCaret" which is called via BaseCaret's painCustomCaret method. If I knew how to get hold of Milos, I'd ask him if this addresses his concerns when he put in that comment (knowing he was breaking something) 10 years ago. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
