sdedic commented on a change in pull request #2324:
URL: https://github.com/apache/netbeans/pull/2324#discussion_r511901776
##########
File path: ide/lsp.client/src/org/netbeans/modules/lsp/client/LSPBindings.java
##########
@@ -232,6 +250,8 @@ private static InitializeResult initServer(Process p,
LanguageServer server, Fil
wcc.setWorkspaceEdit(new WorkspaceEditCapabilities());
wcc.getWorkspaceEdit().setDocumentChanges(true);
wcc.getWorkspaceEdit().setResourceOperations(Arrays.asList(ResourceOperationKind.Create,
ResourceOperationKind.Delete, ResourceOperationKind.Rename));
+ SymbolCapabilities sc = new SymbolCapabilities(new
SymbolKindCapabilities(Arrays.asList(SymbolKind.values())));
+ wcc.setSymbol(sc);
initParams.setCapabilities(new ClientCapabilities(wcc, tdcc, null));
Review comment:
The client capabilities should (?) be used for the standard ones -
https://microsoft.github.io/language-server-protocol/specification except the
`experimental` field, which is not well documented: could be a bag of
capability objects or just the capability properties (?)
I borrowed the implementation from here:
https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/settings/capabilities/InitializationOptionsExtendedClientCapabilities.java
but it can be re-coded to read a bag in `clientCapabiltiies.experimetnal`,
if it is the better way. @lahodaj ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
