eirikbakke commented on pull request #504: URL: https://github.com/apache/netbeans/pull/504#issuecomment-718216963
Can confirm that the patch still works, and that it can be turned on or off. I now also finally understand what it does... With the patch included in the IDE but without the COMPARE_TIMESTAMPS setting, I pretty quickly get the old "Absent Code attribute in method that is not native or abstract" exceptions that I've become used to in the past three years of NetBeans releases (reported on https://issues.apache.org/jira/browse/NETBEANS-430 ). When enabled (with "-J-Dorg.netbeans.modules.java.source.usages.BuildArtifactMapperImpl.COMPARE_TIMESTAMPS=true"), these exceptions go away except when the error is in the same class as is being edited. I've also examined the log messages to confirm that the functionality can be turned on and off. Also looked at a diff between the old and the new version of the patch, and confirmed that it's just cleanup and the system property test. (Figured the log part out... added "-J-Dorg.netbeans.modules.java.source.usages.BuildArtifactMapperImpl.level=100" to netbeans_default_options in netbeans.conf to get the messages showing.) I think this patch should be safe to merge. Thanks for this! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
