JaroslavTulach commented on pull request #2553:
URL: https://github.com/apache/netbeans/pull/2553#issuecomment-752334389


   > I think I have where the contradiction is.
   > The Project API allows to create some LazyLookupProviders.
   > 
   > 
https://github.com/apache/netbeans/blob/49f8d408b0ce827692b7dee5d8db8b6236d23ad2/ide/projectapi/src/org/netbeans/modules/projectapi/LazyLookupProviders.java#L66
   > 
   > This is implemented as a ProxyLookup which has the initial `data` as 
`ImmutableInternalData.EMPTY`.
   > Upon the change of the lookup set we never ask for calling 
`beforeLookup()` so we never actually initialize the data read from the layer 
attributes.
   > 
   > @JaroslavTulach I do not know how to resolve this contradiction, as I do 
not know why is the callBeforeLookup made into an option. What I can do is not 
to use ProjectServiceProvider, but to register a LookupProvider and place the 
SourceGroup instance directly into the Lookup. 
   
   Do I get it right that the problem is in the implementation of 
`@ProjectServiceProvider`? I could get 291eac5 and let the test fail and then 
try to find out what to change in the project modules to make the test pass. I 
may take a look, but I haven't written that code, so I am not going to have 
much advantage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to